Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide failing test for cache-redirect-id-array case #9902

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Provide failing test for cache-redirect-id-array case #9902

wants to merge 5 commits into from

Conversation

aronwoost
Copy link

@aronwoost aronwoost commented Jul 14, 2022 •
edited
Loading

Find all details about the issue here: #9063

Note that it works as expected if the read() function returns false (no array).

Let me know if you have any question.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@aronwoost: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@aronwoost aronwoost changed the title WIP Provide failing test for cache-redirect-id-array case Jul 14, 2022
@aronwoost aronwoost marked this pull request as ready for review July 14, 2022 08:03
@aronwoost aronwoost mentioned this pull request Jul 14, 2022
Open
@jpvajda jpvajda added the 🏓 awaiting-team-response requires input from the apollo team label Jul 14, 2022
@jpvajda jpvajda self-assigned this Sep 1, 2022
@jpvajda
Copy link
Contributor

jpvajda commented Sep 1, 2022

@aronwoost sorry for the delayed review on this! We appreciate the contribution. I'll see if the team can review soon. 🙏

@jpvajda jpvajda removed their assignment Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏓 awaiting-team-response requires input from the apollo team 🛫 in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aronwoost @apollo-cla @jpvajda